Implement the equivalent of io_uring_prep_sendto
#309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implements the equivalent of `io_uring_prep_send_set_addr`, which was already implemented on SendZc, but not yet on the regular Send.
ruuda
commented
Nov 23, 2024
Comment on lines
+1008
to
+1013
| /// Set the destination address, for sending from an unconnected socket. | ||
| /// | ||
| /// When set, `dest_addr_len` must be set as well. | ||
| /// See also `man 3 io_uring_prep_send_set_addr`. | ||
| dest_addr: *const libc::sockaddr = core::ptr::null(), | ||
| dest_addr_len: libc::socklen_t = 0, |
There was a problem hiding this comment.
Because of the generated setters, this generates two of them. This is consistent with SendZc, but I think it would be nicer (for both, although it would be breaking to change SendZc now) to have a single dest_addr(addr: *const libc::sockaddr, addr_len: socklen_t), so it is impossible to forget to specify the length. Is such a thing possible?
Edit: It doesn’t seem so, not without invasive changes to the macro at least. We could do a tuple of course but then the setter is a bit awkward.
There was a problem hiding this comment.
It's not too complicated so I think the status quo is good enough
|
Thank you! |
|
Thanks for the quick release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In liburing, there is
io_uring_prep_sendto, which is implemented as preparing a regularsendfollowed byset_addron the same SQE. This was not yet implemented here forSend, so add it.Fortunately @serzhiio previously implemented the equivalent for
SendZcin #228, so it was easy to adapt that forSend. Thanks serzhiio, this saved me a lot of time!