Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Mutex to work with ?Sized types #339

Merged
merged 1 commit into from
Mar 17, 2024
Merged

Allow Mutex to work with ?Sized types #339

merged 1 commit into from
Mar 17, 2024

Conversation

Phantomical
Copy link
Contributor

std supports this so it would be nice if loom did too. The only changes needed to do it is just adding ?Sized where applicable.

@Phantomical Phantomical changed the title Allow Mutex and RwLock to work with ?Sized types Allow Mutex to work with ?Sized types Mar 17, 2024
@Phantomical
Copy link
Contributor Author

It looks like the Option in RwLock breaks this on 1.65 so I've changed it to only add ?Sized for Mutex.

taiki-e
taiki-e approved these changes Mar 17, 2024
View reviewed changes
Copy link
Member

@taiki-e taiki-e left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@taiki-e taiki-e merged commit a2eda38 into tokio-rs:master Mar 17, 2024
5 checks passed
@Phantomical Phantomical deleted the dyn-sized-mutex branch March 30, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@taiki-e taiki-e taiki-e approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Phantomical @taiki-e