Add TcpSocket, a basic TCP socket builder
#1358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This provides `TcpSocket`, a basic API for building a TCP socket. The goal is not to provide comprehensive coverage of all system options, but to provide an API for the most common cases. This is added now as a replacement for the removal of `TcpStream::connect_std`. The `connect_std` function from v0.6 was used until now as the strategy to set socket option before obtaining a mio TcpStream. Providing some strategy for customizing a `TcpStream` is required for Hyper to be able to upgrade.
|
@Thomasdezeeuw This is ready to go! |
Thomasdezeeuw
approved these changes
Oct 5, 2020
| }) | ||
| } | ||
|
|
||
| pub(crate) fn new_for_addr(addr: SocketAddr) -> io::Result<TcpSocket> { |
There was a problem hiding this comment.
Why not public? Perhaps with a new name: TcpSocket::for_address.
There was a problem hiding this comment.
Mostly to minimize the API surface initially, but I can make it public.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Thomasdezeeuw I'm posting this now for early feedback. The work is not done.
This provides
TcpSocket, a basic API for building a TCP socket. The goal is not to provide comprehensive coverage of all system options, but to provide an API for the most common cases.This is added now as a replacement for the removal of
TcpStream::connect_std. Theconnect_stdfunction from v0.6 was used until now as the strategy to set socket option before obtaining a mio TcpStream.Providing some strategy for customizing a
TcpStreamis required for Hyper to be able to upgrade.The
TcpSocketAPI for Tokio is provided here. There has been some discussion in Discord related to how to handle configuring a TCP socket.I know there is some discussion about using
socket2for advanced socket configuration. I don't believeTcpSocketandsocket2are mutually exclusive.TcpSocketprovides the ability to configure a socket while maintaining mio invariants (non-blocking).