Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove cfg attributes for Solaris #1528

Merged
merged 2 commits into from
Nov 7, 2021

Conversation

Thomasdezeeuw
Copy link
Collaborator

We never really supported Solaris, we pretended it implemented epoll,
but it never did see #1152. As no
one ever committed to being a maintainer for the port I'm removing it
now with this commit.

Instead replace it with illumuos on the CI, which we do support (as it
supports epoll) and for which we do have maintainers.

Also fixes feature flags for some tests files. The test util module requires
both the "os-poll" and "net" features.

src/sys/unix/selector/mod.rs Outdated Show resolved Hide resolved
src/sys/unix/selector/mod.rs Outdated Show resolved Hide resolved
We never really supported Solaris, we pretended it implemented epoll,
but it never did see tokio-rs#1152. As no
one ever committed to being a maintainer for the port I'm removing it
now with this commit.

Instead replace it with illumuos on the CI, which we do support (as it
supports epoll) and for which we do have maintainers.
The test util module requires both the "os-poll" and "net" features.
@Thomasdezeeuw Thomasdezeeuw merged commit dca2134 into tokio-rs:master Nov 7, 2021
@Thomasdezeeuw Thomasdezeeuw deleted the remove-solaris branch November 7, 2021 18:43
Thomasdezeeuw added a commit to Thomasdezeeuw/mio that referenced this pull request Dec 12, 2021
Solaris support was already removed in
tokio-rs#1528, but the readme still
mentioned it.
Thomasdezeeuw added a commit that referenced this pull request Dec 12, 2021
Solaris support was already removed in
#1528, but the readme still
mentioned it.
bdbai pushed a commit to YtFlow/mio-noafd that referenced this pull request May 15, 2022
Solaris support was already removed in
tokio-rs#1528, but the readme still
mentioned it.
stlankes pushed a commit to hermit-os/mio that referenced this pull request Jun 30, 2022
Solaris support was already removed in
tokio-rs#1528, but the readme still
mentioned it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants