Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test x86_64-pc-windows-gnu with Wine on CI #1637

Closed
wants to merge 3 commits into from
Closed

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Nov 30, 2022

This adds test for x86_64-pc-windows-gnu with Wine 7.13 on CI.

This also documents that Wine 7.13+ is supported. EDIT: see #1637 (comment)

cc #1444

@taiki-e
Copy link
Member Author

taiki-e commented Nov 30, 2022

Hmm...

https://github.com/tokio-rs/mio/actions/runs/3583801507/jobs/6029672205

0380:fixme:dbghelp_dwarf:dwarf2_parse_udt_type Unhandled Tag type 0x33 at debug_info(abbrev:000000000056C6F0,symt:00000000003F53C4) in ctx(00000000003E5EF8,L"tcp_stream-4c63397ba5a78afa")

....

winedbg: Internal crash at 00000003AF6D8FE0
error: test failed, to rerun pass `--test tcp_stream`

I'll try more newer wine... EDIT: doesn't works even with the latest wine

@taiki-e taiki-e force-pushed the taiki-e/wine branch 8 times, most recently from 255adb1 to 969624f Compare November 30, 2022 15:20
@taiki-e
Copy link
Member Author

taiki-e commented Nov 30, 2022

Added #[cfg_attr(wine, ignore = "fails on Wine")] to 5 tests that don't work on wine (969624f).

The failures are all in the following form, and I'm not sure what is occurring.

wine: Unhandled page fault on read access to 0000000000000000 at address 00000003AF6D8FE0 (thread 0330), starting debugger...
0360:err:winediag:nodrv_CreateWindow Application tried to create a window, but no driver could be loaded.
0360:err:winediag:nodrv_CreateWindow L"Make sure that your X server is running and that $DISPLAY is set correctly."
test shutdown_both ... Unhandled exception: page fault on read access to 0x0000000000000000 in 64-bit code (0x000003af6d8fe0).
winedbg: Internal crash at 00000003AF6D8FE0

@taiki-e taiki-e force-pushed the taiki-e/wine branch 4 times, most recently from 8b7e20d to 1dfae09 Compare December 2, 2022 16:24
@taiki-e taiki-e marked this pull request as ready for review December 3, 2022 14:31
README.md Outdated Show resolved Hide resolved
@Thomasdezeeuw
Copy link
Collaborator

@taiki-e what is the status of this? I see that some tests are still ignored (that are not ignored on Windows), so it's still not 100% supported?

@taiki-e taiki-e force-pushed the taiki-e/wine branch 2 times, most recently from 3be816c to 2109ba9 Compare February 13, 2023 16:27
@taiki-e
Copy link
Member Author

taiki-e commented Feb 13, 2023

I see that some tests are still ignored (that are not ignored on Windows), so it's still not 100% supported?

Yeah, some tests are still failing (even with the latest wine), so they are ignored.

Ideally, I would like to investigate and fix (if possible) the failure here, but I don't have the time or knowledge to investigate that at this time. (Perhaps I need to start by testing windows-gnu on CI with windows host to know if the failure is wine-specific or a mingw issue.)

@taiki-e taiki-e marked this pull request as draft June 12, 2023 08:51
@Thomasdezeeuw
Copy link
Collaborator

I'm going to close this due to age and because it's incomplete. @taiki-e thanks for the effort!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants