Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update windows-sys to 0.48 #1663

Merged
merged 1 commit into from
Apr 3, 2023
Merged

Update windows-sys to 0.48 #1663

merged 1 commit into from
Apr 3, 2023

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Apr 1, 2023

No description provided.

@taiki-e taiki-e requested a review from carllerche as a code owner April 1, 2023 07:26
@Thomasdezeeuw Thomasdezeeuw merged commit bc54c25 into master Apr 3, 2023
@Thomasdezeeuw
Copy link
Collaborator

Thanks @taiki-e

@TheBlueMatt
Copy link

Given this introduced a dependency on windows-targets, which has no MSRV guarantees between patch versions at all (or seems not to, per the maintainer's comment at tokio-rs/tokio#5934 (comment)) should this be reverted?

@Thomasdezeeuw
Copy link
Collaborator

It's really not great to have the same conversation in three issues/prs, but I've responded here: microsoft/windows-rs#2568 (comment).

@TheBlueMatt
Copy link

Given the comment on tokio the response from windows-sys/windows-targets seemed to be "not supported" and ultimately the issue wasn't in tokio but in mio (in the sense that it depends on something with no MSRV provided), so this felt like the right place :). Though, indeed, it did lead to a fragmented conversation which sucks. I've responded there so let's hash out there what windows-sys/windows-targets wants to support (or not) and then we can come back here and figure out how that impacts mio.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants