Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix FreeBSD CI test #1668

Merged
merged 1 commit into from
May 2, 2023
Merged

Fix FreeBSD CI test #1668

merged 1 commit into from
May 2, 2023

Conversation

KolbyML
Copy link
Contributor

@KolbyML KolbyML commented May 2, 2023

Curl is failing on CI causing FreeBSD CI test to fail on my other PR https://github.com/tokio-rs/mio/pull/1667/checks?check_run_id=13155549454

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=270940 I found other references to the same bug

Curl 7.88.1 up fails. Curl is already installed on FreeBSD so removing the command to update it fixes this issue

Copy link
Collaborator

@asomers asomers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Another option is to use fetch, which is built into the base system rather than from ports. Use it like this:

fetch https://sh.rustup.rs -o rustup.sh
sh rustup.sh -y --profile=minimal

@KolbyML
Copy link
Contributor Author

KolbyML commented May 2, 2023

fetch https://sh.rustup.rs -o rustup.sh

I updated the PR to use your suggested solution since base system would be ideal I agree

@KolbyML KolbyML requested a review from asomers May 2, 2023 01:32
@Thomasdezeeuw Thomasdezeeuw merged commit 0757ec8 into tokio-rs:master May 2, 2023
@Thomasdezeeuw
Copy link
Collaborator

Thanks @KolbyML

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants