-
Notifications
You must be signed in to change notification settings - Fork 743
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix various Clippy lints #1777
Fix various Clippy lints #1777
Conversation
Fixes clippy::legacy_numeric_constants.
Way too many false positives. Backport of 8a1bfe1
e093d78
to
ab2ab15
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like you missed one.
error: read amount is not handled
--> tests/close_on_drop.rs:62:23
|
62 | match self.cli.read(&mut buf) {
| ^^^^^^^^^^^^^^^^^^^^^^^
|
= help: use `Read::read_exact` instead, or handle partial reads
note: the result is consumed here, but the amount of I/O bytes remains unhandled
--> tests/close_on_drop.rs:64:21
|
64 | Ok(_) => panic!("the client socket should not be readable"),
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount
= note: `#[deny(clippy::unused_io_amount)]` on by default
I probably missed a bunch because it doesn't trigger for me locally, only on the CI for some reason. |
I just love how it switches between some 1 error in the tests, then 1 error in the examples and back to the tests again... |
My guess is the rustc version. Clippy lints can vary a lot. |
Doesn't seem to trigger any more? At least not on the CI. |
Also see #1776