Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add interests associated constants to net types #986

Closed
wants to merge 1 commit into from

Conversation

Thomasdezeeuw
Copy link
Collaborator

Useful to quickly register a type with the correct (or most used)
interests.

Useful to quickly register a type with the correct (or most used)
interests.
@Thomasdezeeuw Thomasdezeeuw mentioned this pull request Jun 17, 2019
@Thomasdezeeuw Thomasdezeeuw added this to the v0.7 milestone Jun 17, 2019
@carllerche
Copy link
Member

I'm a little hesitant to add this as it is mostly for convenience vs. required for some functionality. I can see how common registrations could be nice from an ergonomics POV, but if we are going w/ ergonomics, I don't know if a constant would be best.

For example, there could be registry.register_default(&my_socket, my_token). These kinds of APIs we could experiment w/ first in an external crate before committing to them here?

@Thomasdezeeuw
Copy link
Collaborator Author

Fair enough, then I'll close this.

@Thomasdezeeuw Thomasdezeeuw deleted the type-interests branch June 17, 2019 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants