Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Release version 0.12.5 #1050

Merged
merged 1 commit into from
May 8, 2024

Conversation

caspermeijn
Copy link
Collaborator

PROST! is a Protocol Buffers implementation for the Rust Language. prost generates simple, idiomatic Rust code from proto2 and proto3 files.

This patch update brings new fixes:

Documentation

Internal

_PROST!_ is a [Protocol Buffers](https://developers.google.com/protocol-buffers/) implementation for the [Rust Language](https://www.rust-lang.org/). `prost` generates simple, idiomatic Rust code from `proto2` and `proto3` files.

This patch update brings new fixes:

- fix: include_file should handle proto without package (tokio-rs#1002)
- Place Config::format behind the format feature flag
- Handle keyword `Self` after stripping enum type prefix (tokio-rs#998)

## Documentation
- fix(readme): fix the link and badge for CI (tokio-rs#1049)

## Internal
- style(codegen): `Syntax` to a separate file (tokio-rs#1029)
- chore(codegen): extract c string escaping to a separate file (tokio-rs#1028)
- style(prost-build): `CodeGenerator::boxed` method (tokio-rs#1019)
- style(prost-build): Consolidate field data into struct (tokio-rs#1017)
- style(prost-build): `BytesType and MapType` into a `collections` module. (tokio-rs#1030)
- style(prost-build): Split `Config` and `Module` into a separate module and files (tokio-rs#1020)
- style(prost-build): prost_path helper (tokio-rs#1018)
- style: Fix toml indent (tokio-rs#1048)
- style: Fix clippy warnings and enable clippy in CI (tokio-rs#1008)
- build: Use git submodule to download protobuf sources (tokio-rs#1014)
- ci: Add TOML validation with `taplo` (tokio-rs#1034)
- tests: Create a separate tempdir for each test (tokio-rs#1044)
- tests: Remove GoogleMessage3 and GoogleMessage4 benchmarks (tokio-rs#1037)
- chore: Update internal crates to Rust edition 2021 (tokio-rs#1039)
- chore: Update crate descriptions (tokio-rs#1038)
- chore: Fix clippy checks in CI (tokio-rs#1032)
- chore: Add Casper Meijn as author (tokio-rs#1025)
Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran cargo semver-checks just to make sure there were not any breaking changes and it returned some small changes in the build crate:

prost on  release_0.12.5 via 🦀 v1.76.0
❯ cargo semver-checks
     Parsing prost v0.12.5 (current)
      Parsed [   3.316s] (current)
     Parsing prost v0.12.4 (baseline)
      Parsed [   2.738s] (baseline)
    Checking prost v0.12.4 -> v0.12.5 (minor change)
     Checked [   0.026s] 66 checks; 66 passed, 6 unnecessary
    Finished [   6.088s] prost
     Parsing prost-build v0.12.5 (current)
      Parsed [   4.411s] (current)
     Parsing prost-build v0.12.4 (baseline)
      Parsed [   4.185s] (baseline)
    Checking prost-build v0.12.4 -> v0.12.5 (minor change)
     Checked [   0.006s] 66 checks; 65 passed, 1 failed, 6 unnecessary

--- failure function_missing: pub fn removed or renamed ---

Description:
A publicly-visible function cannot be imported by its prior path. A `pub use` may have been removed, or the function itself may have been renamed or removed entirely.
        ref: https://doc.rust-lang.org/cargo/reference/semver.html#item-remove
       impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.31.0/src/lints/function_missing.ron

Failed in:
  function prost_build::protoc_from_env, previously in file /Users/lucio/.cargo/registry/src/index.crates.io-6f17d22bba15001f/prost-build-0.12.4/src/lib.rs:1506
  function prost_build::error_message_protoc_not_found, previously in file /Users/lucio/.cargo/registry/src/index.crates.io-6f17d22bba15001f/prost-build-0.12.4/src/lib.rs:1512
  function prost_build::protoc_include_from_env, previously in file /Users/lucio/.cargo/registry/src/index.crates.io-6f17d22bba15001f/prost-build-0.12.4/src/lib.rs:1532
     Summary semver requires new major version: 1 major and 0 minor checks failed
    Finished [   8.611s] prost-build
     Parsing prost-types v0.12.5 (current)
      Parsed [   2.951s] (current)
     Parsing prost-types v0.12.4 (baseline)
      Parsed [   2.832s] (baseline)
    Checking prost-types v0.12.4 -> v0.12.5 (minor change)
     Checked [   0.078s] 66 checks; 66 passed, 6 unnecessary
    Finished [   5.876s] prost-types

Can you verify this before we merge?

@caspermeijn
Copy link
Collaborator Author

Can you verify this before we merge?

Oops, I should have mentioned that. I noticed it also when I ran cargo semver-checks.

In one of the PRs this was discussed. I am of the opinion that it is OK, as these should have been private in the first place.

Do you agree this is acceptable? If not, I will create a PR to revert it.

Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@caspermeijn sounds good, just be aware that we may need to yank if someone runs into issues if they use it. But I agree that its likely not going to be an issue so we can move foward with this release.

@LucioFranco LucioFranco added this pull request to the merge queue May 8, 2024
Merged via the queue into tokio-rs:master with commit 548739a May 8, 2024
15 checks passed
@caspermeijn caspermeijn deleted the release_0.12.5 branch May 20, 2024 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants