Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Remove use of legacy numeric constants #1089

Merged
merged 1 commit into from
Jul 12, 2024

Conversation

caspermeijn
Copy link
Collaborator

Cargo clippy reports:

warning: usage of a legacy numeric method
  --> prost/src/lib.rs:71:24
   |
71 |     if length > usize::max_value() as u64 {
   |                        ^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
help: use the associated constant instead
   |
71 |     if length > usize::MAX as u64 {
   |                        ~~~

@caspermeijn caspermeijn force-pushed the legacy_numeric_constants branch from 8180062 to 6a9972f Compare June 25, 2024 16:46
Cargo clippy reports:

```
warning: usage of a legacy numeric method
  --> prost/src/lib.rs:71:24
   |
71 |     if length > usize::max_value() as u64 {
   |                        ^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants
help: use the associated constant instead
   |
71 |     if length > usize::MAX as u64 {
   |                        ~~~
```
@caspermeijn caspermeijn force-pushed the legacy_numeric_constants branch from 6a9972f to 37cdf51 Compare June 25, 2024 17:28
@caspermeijn caspermeijn added this pull request to the merge queue Jul 12, 2024
Merged via the queue into tokio-rs:master with commit ee61946 Jul 12, 2024
16 checks passed
@caspermeijn caspermeijn deleted the legacy_numeric_constants branch July 12, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant