style(generated-code): use Self in as_str_name #1154
Merged
+68
−69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caspermeijn
requested changes
Sep 11, 2024
There was a problem hiding this comment.
Thank you for this styling change.
I would like to prevent regression via CI, but I can't think of a way to do it reliably. I would rather not enable clippy::use_self as it is in nursery.
Please change the commit message and title to better reflect the changes. For example:
style(generated-code): Use `Self` in `as_str_name`
Fixes `clippy::use_self` violations
thecaralice
force-pushed
the
use-self
branch
from
f085c6c
to
54faa2d
Compare
caspermeijn
changed the title
caspermeijn
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes
as_str_namegeneratematch selfusingSelf::where possible, consistent withfrom_str_name