Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style(generated-code): use Self in as_str_name #1154

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

thecaralice
Copy link
Contributor

Makes as_str_name generate match self using Self:: where possible, consistent with from_str_name

Copy link
Collaborator

@caspermeijn caspermeijn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this styling change.

I would like to prevent regression via CI, but I can't think of a way to do it reliably. I would rather not enable clippy::use_self as it is in nursery.

Please change the commit message and title to better reflect the changes. For example:

style(generated-code): Use `Self` in `as_str_name`

Fixes `clippy::use_self` violations
@caspermeijn caspermeijn changed the title build: fix clippy::use_self style(generated-code): use Self in as_str_name Sep 13, 2024
Copy link
Collaborator

@caspermeijn caspermeijn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution

@caspermeijn caspermeijn added this pull request to the merge queue Sep 13, 2024
Merged via the queue into tokio-rs:master with commit 4b1b982 Sep 13, 2024
13 of 16 checks passed
@thecaralice thecaralice deleted the use-self branch September 21, 2024 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants