Remove path type generic for better ergonomic #496
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LucioFranco
requested changes
Jul 6, 2021
aquarhead
changed the title
|
@aquarhead looks like there is a test failure, could you fix that then we can merge this? |
|
I'll take a look |
|
So seems this will break if It seems this change would improve ergonomics when I have |
LucioFranco
approved these changes
Jul 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This could be especially useful when one parameter (e.g.
protos) is dynamically collected while the other (includes) is statically defined. Splitting the type should makecompile_protoseasier to use, I also changed a few instances where type conversion was used to show the impact.