Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes 905, fix: Use full path of Result type + unit test + Option unti test #917

Merged
merged 5 commits into from
Sep 15, 2023
Merged

Fixes 905, fix: Use full path of Result type + unit test + Option unti test #917

merged 5 commits into from
Sep 15, 2023

Conversation

anstylian
Copy link
Contributor

@anstylian anstylian commented Sep 14, 2023

Same as PR #916 plus one commit that contains a unit test that covers the case where Option was used instead of ::core::option::Option.

PR #916 description:
this pull request contains 3 commits:

  1. add cmake and ninja in the flake: Was needed to run cargo test from the test directory
  2. unit-test added to replicate issue: Replicates the error described in issue Type error regression when using enum called Result #905
  3. fix: Use full path of Result type: Fixes issue
    Type error regression when using enum called Result #905

@anstylian anstylian changed the title Option unti test Fixes 905 + Option unti test Sep 14, 2023
@anstylian anstylian changed the title Fixes 905 + Option unti test Fixes 905, fix: Use full path of Result type + unit test + Option unti test Sep 14, 2023
Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks!

@LucioFranco LucioFranco merged commit 6079136 into tokio-rs:master Sep 15, 2023
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants