Allow itertools 0.12 #948

kayabaNerve · 2023-11-22T23:00:05Z

0.12 didn't change the syntax of any APIs in-use.

Additionally, the tests do pass with 0.12.

kayabaNerve · 2023-12-05T07:08:50Z

@LucioFranco Would you mind taking a look when you have a moment? Pinging you as you seem to be a maintainer. Apologies if such a ping is misplaced.

emilio · 2024-02-04T12:38:31Z

can we get this merged? Would be good to avoid unnecessary duplicate dependencies

caspermeijn

Please rebase to latest master to fix conflict

caspermeijn · 2024-03-08T09:11:56Z

prost-build/Cargo.toml

@@ -23,7 +23,7 @@ cleanup-markdown = ["pulldown-cmark", "pulldown-cmark-to-cmark"]
 [dependencies]
 bytes = { version = "1", default-features = false }
 heck = "0.4"
-itertools = { version = ">=0.10, <0.12", default-features = false, features = ["use_alloc"] }
+itertools = { version = ">=0.10, <0.13", default-features = false, features = ["use_alloc"] }


Personally, I think this syntax explains better the intent of the version bounds.

Suggested change

itertools = { version = ">=0.10, <0.13", default-features = false, features = ["use_alloc"] }

itertools = { version = ">=0.10, <=0.12", default-features = false, features = ["use_alloc"] }

Wouldn't this disallow e.g. 0.12.1?

Wouldn't this disallow e.g. 0.12.1?

Have you tested that? I believe my suggestion is equivalent.

$ cargo update Updating crates.io index Updating itertools v0.11.0 -> v0.12.1

You are right, sorry for the noise.

0.12 didn't change the syntax of any APIs in-use.

kayabaNerve · 2024-03-20T11:14:02Z

Done.

caspermeijn

Thanks for your contribution

kayabaNerve · 2024-03-22T19:01:21Z

Happy to :)

@generated

_PROST!_ is a [Protocol Buffers](https://developers.google.com/protocol-buffers/) implementation for the [Rust Language](https://www.rust-lang.org/). `prost` generates simple, idiomatic Rust code from `proto2` and `proto3` files. This patch updates brings a few new features and fixes: - Bump MSRV to 1.70 (minimum supported Rust version) - Rename cargo feature `prost-derive` to `derive` (tokio-rs#992) - Add @generated comment on top of generated files (tokio-rs#935) - Optimize implementation of prost::Name when generated by prost-build (tokio-rs#956) ## Dependencies - build(deps): Allow itertools 0.12 (tokio-rs#948) - build(deps): Allow heck 0.5 (tokio-rs#1012) - build(deps): Allow multimap 0.10 (tokio-rs#1013) ## Documentation - Improve protoc not found error message (tokio-rs#937) - build: Add development container config (tokio-rs#949) - docs: Fixed README typos (tokio-rs#952 / tokio-rs#967 / tokio-rs#970) ## Internal - chore: Fix minimal versions (tokio-rs#920) - fix: fq_message_name should begin with one dot (tokio-rs#981) - improve encode_varint performance by bounding its loop (tokio-rs#940) - style: Remove duplicate function call (tokio-rs#989) - test: Improve test decode_varint_slow (tokio-rs#977) - chore: Add dep: prefix to feature dependencies (tokio-rs#919) - Minor clippy lint fixes. (tokio-rs#1006) - chore: Use taiki-e/install-action to setup cargo-machete (tokio-rs#909) - chore: Remove which dependency. (tokio-rs#962) - chore: Update to actions/checkout@v4 (tokio-rs#910) ``` $ cargo semver-checks --workspace Parsing prost v0.12.4 (current) Parsed [ 4.348s] (current) Parsing prost v0.12.3 (baseline, cached) Parsed [ 0.099s] (baseline) Checking prost v0.12.3 -> v0.12.4 (minor change) Checked [ 0.029s] 61 checks; 61 passed, 6 unnecessary Finished [ 4.481s] prost Parsing prost-build v0.12.4 (current) Parsed [ 5.488s] (current) Parsing prost-build v0.12.3 (baseline) Parsed [ 3.819s] (baseline) Checking prost-build v0.12.3 -> v0.12.4 (minor change) Checked [ 0.005s] 61 checks; 61 passed, 6 unnecessary Finished [ 9.319s] prost-build Parsing prost-types v0.12.4 (current) Parsed [ 3.150s] (current) Parsing prost-types v0.12.3 (baseline) Parsed [ 3.192s] (baseline) Checking prost-types v0.12.3 -> v0.12.4 (minor change) Checked [ 0.075s] 61 checks; 61 passed, 6 unnecessary Finished [ 6.434s] prost-types ```

@generated

_PROST!_ is a [Protocol Buffers](https://developers.google.com/protocol-buffers/) implementation for the [Rust Language](https://www.rust-lang.org/). `prost` generates simple, idiomatic Rust code from `proto2` and `proto3` files. This patch update brings new features and fixes: - Bump MSRV to 1.70 (minimum supported Rust version) - Rename cargo feature `prost-derive` to `derive` (tokio-rs#992) - Add @generated comment on top of generated files (tokio-rs#935) - Optimize implementation of prost::Name when generated by prost-build (tokio-rs#956) ## Dependencies - build(deps): Allow itertools 0.12 (tokio-rs#948) - build(deps): Allow heck 0.5 (tokio-rs#1012) - build(deps): Allow multimap 0.10 (tokio-rs#1013) ## Documentation - Improve protoc not found error message (tokio-rs#937) - build: Add development container config (tokio-rs#949) - docs: Fixed README typos (tokio-rs#952 / tokio-rs#967 / tokio-rs#970) ## Internal - chore: Fix minimal versions (tokio-rs#920) - fix: fq_message_name should begin with one dot (tokio-rs#981) - improve encode_varint performance by bounding its loop (tokio-rs#940) - style: Remove duplicate function call (tokio-rs#989) - test: Improve test decode_varint_slow (tokio-rs#977) - chore: Add dep: prefix to feature dependencies (tokio-rs#919) - Minor clippy lint fixes. (tokio-rs#1006) - chore: Use taiki-e/install-action to setup cargo-machete (tokio-rs#909) - chore: Remove which dependency. (tokio-rs#962) - chore: Update to actions/checkout@v4 (tokio-rs#910)

@generated

_PROST!_ is a [Protocol Buffers](https://developers.google.com/protocol-buffers/) implementation for the [Rust Language](https://www.rust-lang.org/). `prost` generates simple, idiomatic Rust code from `proto2` and `proto3` files. This patch update brings new features and fixes: - Bump MSRV to 1.70 (minimum supported Rust version) - Rename cargo feature `prost-derive` to `derive` (tokio-rs#992) - Add @generated comment on top of generated files (tokio-rs#935) - Optimize implementation of prost::Name when generated by prost-build (tokio-rs#956) ## Dependencies - build(deps): Allow itertools 0.12 (tokio-rs#948) - build(deps): Allow heck 0.5 (tokio-rs#1012) - build(deps): Allow multimap 0.10 (tokio-rs#1013) ## Documentation - Improve protoc not found error message (tokio-rs#937) - build: Add development container config (tokio-rs#949) - docs: Fixed README typos (tokio-rs#952 / tokio-rs#967 / tokio-rs#970) ## Internal - chore: Fix minimal versions (tokio-rs#920) - fix: fq_message_name should begin with one dot (tokio-rs#981) - improve encode_varint performance by bounding its loop (tokio-rs#940) - style: Remove duplicate function call (tokio-rs#989) - test: Improve test decode_varint_slow (tokio-rs#977) - chore: Add dep: prefix to feature dependencies (tokio-rs#919) - Minor clippy lint fixes. (tokio-rs#1006) - chore: Use taiki-e/install-action to setup cargo-machete (tokio-rs#909) - chore: Remove which dependency. (tokio-rs#962) - chore: Update to actions/checkout@v4 (tokio-rs#910)

@generated

_PROST!_ is a [Protocol Buffers](https://developers.google.com/protocol-buffers/) implementation for the [Rust Language](https://www.rust-lang.org/). `prost` generates simple, idiomatic Rust code from `proto2` and `proto3` files. This patch update brings new features and fixes: - Bump MSRV to 1.70 (minimum supported Rust version) - Rename cargo feature `prost-derive` to `derive` (#992) - Add @generated comment on top of generated files (#935) - Optimize implementation of prost::Name when generated by prost-build (#956) ## Dependencies - build(deps): Allow itertools 0.12 (#948) - build(deps): Allow heck 0.5 (#1012) - build(deps): Allow multimap 0.10 (#1013) ## Documentation - Improve protoc not found error message (#937) - build: Add development container config (#949) - docs: Fixed README typos (#952 / #967 / #970) ## Internal - chore: Fix minimal versions (#920) - fix: fq_message_name should begin with one dot (#981) - improve encode_varint performance by bounding its loop (#940) - style: Remove duplicate function call (#989) - test: Improve test decode_varint_slow (#977) - chore: Add dep: prefix to feature dependencies (#919) - Minor clippy lint fixes. (#1006) - chore: Use taiki-e/install-action to setup cargo-machete (#909) - chore: Remove which dependency. (#962) - chore: Update to actions/checkout@v4 (#910)

@generated

_PROST!_ is a [Protocol Buffers](https://developers.google.com/protocol-buffers/) implementation for the [Rust Language](https://www.rust-lang.org/). `prost` generates simple, idiomatic Rust code from `proto2` and `proto3` files. This patch update brings new features and fixes: - Bump MSRV to 1.70 (minimum supported Rust version) - Rename cargo feature `prost-derive` to `derive` (tokio-rs#992) - Add @generated comment on top of generated files (tokio-rs#935) - Optimize implementation of prost::Name when generated by prost-build (tokio-rs#956) ## Dependencies - build(deps): Allow itertools 0.12 (tokio-rs#948) - build(deps): Allow heck 0.5 (tokio-rs#1012) - build(deps): Allow multimap 0.10 (tokio-rs#1013) ## Documentation - Improve protoc not found error message (tokio-rs#937) - build: Add development container config (tokio-rs#949) - docs: Fixed README typos (tokio-rs#952 / tokio-rs#967 / tokio-rs#970) ## Internal - chore: Fix minimal versions (tokio-rs#920) - fix: fq_message_name should begin with one dot (tokio-rs#981) - improve encode_varint performance by bounding its loop (tokio-rs#940) - style: Remove duplicate function call (tokio-rs#989) - test: Improve test decode_varint_slow (tokio-rs#977) - chore: Add dep: prefix to feature dependencies (tokio-rs#919) - Minor clippy lint fixes. (tokio-rs#1006) - chore: Use taiki-e/install-action to setup cargo-machete (tokio-rs#909) - chore: Remove which dependency. (tokio-rs#962) - chore: Update to actions/checkout@v4 (tokio-rs#910)

0.12 didn't change the syntax of any APIs in-use.

yotamofek mentioned this pull request Dec 30, 2023

build(deps): update to itertools 0.12 #969

Closed

fornwall mentioned this pull request Jan 23, 2024

Mark compatibility with itertools 0.12 #971

Closed

caspermeijn reviewed Mar 8, 2024

View reviewed changes

Allow itertools 0.12

12ff142

0.12 didn't change the syntax of any APIs in-use.

kayabaNerve force-pushed the master branch from 109d709 to 12ff142 Compare March 20, 2024 11:13

caspermeijn approved these changes Mar 22, 2024

View reviewed changes

caspermeijn added this pull request to the merge queue Mar 22, 2024

Merged via the queue into tokio-rs:master with commit 82d7774 Mar 22, 2024
12 checks passed

caspermeijn mentioned this pull request Mar 28, 2024

Bump itertools version to allow 0.12 #963

Closed

caspermeijn mentioned this pull request Apr 5, 2024

chore: Release version 0.12.4 #1024

Merged

gibbz00 pushed a commit to gibbz00/prost that referenced this pull request Apr 6, 2024

Allow itertools 0.12 (tokio-rs#948)

44db742

0.12 didn't change the syntax of any APIs in-use.

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow itertools 0.12 #948

Allow itertools 0.12 #948

kayabaNerve commented Nov 22, 2023

kayabaNerve commented Dec 5, 2023

emilio commented Feb 4, 2024

caspermeijn left a comment

caspermeijn Mar 8, 2024

embe-pw Mar 8, 2024

caspermeijn Mar 8, 2024

embe-pw Mar 8, 2024

kayabaNerve commented Mar 20, 2024

caspermeijn left a comment

kayabaNerve commented Mar 22, 2024

	itertools = { version = ">=0.10, <0.13", default-features = false, features = ["use_alloc"] }
	itertools = { version = ">=0.10, <=0.12", default-features = false, features = ["use_alloc"] }

Allow itertools 0.12 #948

Allow itertools 0.12 #948

Conversation

kayabaNerve commented Nov 22, 2023

kayabaNerve commented Dec 5, 2023

emilio commented Feb 4, 2024

caspermeijn left a comment

Choose a reason for hiding this comment

caspermeijn Mar 8, 2024

Choose a reason for hiding this comment

embe-pw Mar 8, 2024

Choose a reason for hiding this comment

caspermeijn Mar 8, 2024

Choose a reason for hiding this comment

embe-pw Mar 8, 2024

Choose a reason for hiding this comment

kayabaNerve commented Mar 20, 2024

caspermeijn left a comment

Choose a reason for hiding this comment

kayabaNerve commented Mar 22, 2024