Make Slab::new const on Rust 1.39+, Use #[track_caller] on Rust 1.46+ #119

taiki-e · 2022-07-09T07:05:21Z

Closes #87
Closes #90

Darksonn · 2022-07-09T11:28:29Z

src/lib.rs

+    #[cfg(not(slab_no_const_vec_new))]
+    pub const fn new() -> Self {


The fact that const depends on the version should probably be documented.

Updated docs.

notgull · 2022-07-09T14:29:38Z

src/lib.rs

-    pub fn new() -> Slab<T> {
-        Slab::with_capacity(0)
+    #[cfg(not(slab_no_const_vec_new))]
+    pub const fn new() -> Self {


You could use the const-fn crate here to avoid code deduplication.

It is my crate, but it doesn't yet implement the behavior I want.

slab/build.rs

Lines 15 to 17 in 56e7947

// Note that this is `no_`*, not `has_*`. This allows treating as the latest

// stable rustc is used when the build script doesn't run. This is useful

// for non-cargo build systems that don't run the build script.

taiki-e requested review from hawkw and Darksonn July 9, 2022 07:05

Darksonn approved these changes Jul 9, 2022

View reviewed changes

notgull reviewed Jul 9, 2022

View reviewed changes

taiki-e added 2 commits July 10, 2022 02:09

Make Slab::new const on Rust 1.39+

eebc869

Use #[track_caller] on Rust 1.46+

56e7947

taiki-e force-pushed the rollup branch from c4f3090 to 56e7947 Compare July 9, 2022 17:13

taiki-e merged commit 42c7f1a into master Jul 9, 2022

taiki-e deleted the rollup branch July 9, 2022 17:21

taiki-e mentioned this pull request Jul 19, 2022

Release 0.4.7 #120

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make Slab::new const on Rust 1.39+, Use #[track_caller] on Rust 1.46+ #119

Make Slab::new const on Rust 1.39+, Use #[track_caller] on Rust 1.46+ #119

taiki-e commented Jul 9, 2022

Darksonn Jul 9, 2022

taiki-e Jul 9, 2022

notgull Jul 9, 2022

taiki-e Jul 9, 2022

		#[cfg(not(slab_no_const_vec_new))]
		pub const fn new() -> Self {

	// Note that this is `no_`, not `has_`. This allows treating as the latest
	// stable rustc is used when the build script doesn't run. This is useful
	// for non-cargo build systems that don't run the build script.

Make Slab::new const on Rust 1.39+, Use #[track_caller] on Rust 1.46+ #119

Make Slab::new const on Rust 1.39+, Use #[track_caller] on Rust 1.46+ #119

Conversation

taiki-e commented Jul 9, 2022

Darksonn Jul 9, 2022

Choose a reason for hiding this comment

taiki-e Jul 9, 2022

Choose a reason for hiding this comment

notgull Jul 9, 2022

Choose a reason for hiding this comment

taiki-e Jul 9, 2022

Choose a reason for hiding this comment