This repository has been archived by the owner on Sep 13, 2018. It is now read-only.
Generalize TcpServer::serve's service a bit #130
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The services accepted by
TcpServer::serve
wire up the service'srequest/response types the underlying request/response types of the
BindServer
implementation. These types tend to be what we want for the simple case (non
streaming), but for the streaming case they have the
tokio_proto::streaming::Message
type wired in.The
Message
type typically isn't what libraries want as the request/responsetypes for their services, so this PR generalizes to use
From
andInto
toensure that custom types can still be used so long as they can be converted.
I think this sould be backwards compatible as well (not causing inference
regressions), hopefully at least.