-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Determine MSRV Policy #239
Comments
I think it would be better to revert f6cb0ed at least for the next release |
We don't plan on having an MSRV policy right now. This project is pretty early on in its lifecycle and very much not stable yet, so we don't plan on having an MSRV policy until later. What is the reason that you need a lower MSRV? 1.65 is not very new, given that rust 1.67 is currently the latest one out. |
Ok, I see that there is no MSRV policy right now. Just expected some and expected some policy to be aligned with tokio somehow someday. I, personally, think that MSRV not thought out in general, because it is quite common to just bump MSRV in the project without any indication. This result in situations like - tokio-rs/tokio#5048 I created this issue because:
|
I think that at least specifying the current MSRV would be good. |
I see that current master require 1.65 for 1
let...else
statement and 1.64 for fewstd::future::poll_fn
usages.I don't think it is great, since these are too fresh Rust versions.
Also it would be good to provide clear MSRV guarantees in Readme and include this MSRV in CI.
The text was updated successfully, but these errors were encountered: