Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't use OnceCell for 1.18.x LTS release #5048

Merged
merged 7 commits into from
Sep 26, 2022
Merged

Don't use OnceCell for 1.18.x LTS release #5048

merged 7 commits into from
Sep 26, 2022

Conversation

Darksonn
Copy link
Contributor

The latest OnceCell release is not compatible with the MSRV of this LTS release. This PR adds a simple OnceCell implementation to Tokio and uses it instead.

@Darksonn Darksonn added the A-tokio Area: The main tokio crate label Sep 25, 2022
@github-actions github-actions bot added the R-loom Run loom tests on this PR label Sep 25, 2022
@Darksonn Darksonn mentioned this pull request Sep 25, 2022
Closed
@Darksonn
Copy link
Contributor Author

I disabled the custom-executor example as it uses OnceCell and opened #5049.

hds
hds approved these changes Sep 25, 2022
View reviewed changes
Copy link
Contributor

@hds hds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Darksonn Darksonn merged commit 05e6614 into tokio-1.18.x Sep 26, 2022
@Darksonn Darksonn deleted the alice/once-cell-18 branch September 26, 2022 08:41
This was referenced Sep 26, 2022
Merged
Merged
Merged
@Turbo87 Turbo87 mentioned this pull request Sep 28, 2022
Closed
dbischof90 pushed a commit to dbischof90/tokio that referenced this pull request Oct 1, 2022
@Darksonn @dbischof90
chore: don't use once_cell for 1.18.x LTS release (tokio-rs#5048)
b78e0ea 
The latest release of once_cell has an MSRV that is incompatible with the MSRV of the 1.18.x LTS release.
crapStone pushed a commit to Calciumdibromid/CaBr2 that referenced this pull request Oct 5, 2022
Update Rust crate tokio to 1.21.2 (#1566)
4cb8bc5 
This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
| [tokio](https://tokio.rs) ([source](https://github.com/tokio-rs/tokio)) | dependencies | patch | `1.21.1` -> `1.21.2` |
| [tokio](https://tokio.rs) ([source](https://github.com/tokio-rs/tokio)) | dev-dependencies | patch | `1.21.1` -> `1.21.2` |

---

### Release Notes

<details>
<summary>tokio-rs/tokio</summary>

### [`v1.21.2`](https://github.com/tokio-rs/tokio/releases/tag/tokio-1.21.2)

[Compare Source](tokio-rs/tokio@tokio-1.21.1...tokio-1.21.2)

##### 1.21.2 (September 27, 2022)

This release removes the dependency on the `once_cell` crate to restore the MSRV of 1.21.x, which is the latest minor version at the time of release. ([#&#8203;5048])

[#&#8203;5048]: tokio-rs/tokio#5048

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about these updates again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, click this checkbox.

---

This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzMi4yMDQuNSIsInVwZGF0ZWRJblZlciI6IjMyLjIwOC4wIn0=-->

Co-authored-by: cabr2-bot <cabr2.help@gmail.com>
Reviewed-on: https://codeberg.org/Calciumdibromid/CaBr2/pulls/1566
Reviewed-by: crapStone <crapstone@noreply.codeberg.org>
Co-authored-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
Co-committed-by: Calciumdibromid Bot <cabr2_bot@noreply.codeberg.org>
@taiki-e taiki-e mentioned this pull request Nov 21, 2022
Closed
@yuri-rs yuri-rs mentioned this pull request Feb 21, 2023
Open
kodiakhq bot pushed a commit to pdylanross/fatigue that referenced this pull request Aug 23, 2023
@dependabot
chore: Bump tokio from 1.16.1 to 1.20.5 (#182)
f53ea63 
Bumps tokio from 1.16.1 to 1.20.5.

Release notes
Sourced from tokio's releases.

Tokio v1.20.5
1.20.5 (May 28, 2023)
Forward ports 1.18.6 changes.
Fixed

deps: disable default features for mio (#5728)

#5728: tokio-rs/tokio#5728
Tokio v1.20.2
1.20.2 (September 27, 2022)
This release removes the dependency on the once_cell crate to restore the MSRV of the 1.20.x LTS release. (#5048)
#5048: tokio-rs/tokio#5048
Tokio v1.20.1
1.20.1 (July 25, 2022)
Fixed

chore: fix version detection in build script (#4860)

#4860: tokio-rs/tokio#4860
Tokio v1.20.0
1.20.0 (July 12, 2022)
Added

tokio: add track_caller to public APIs (#4772, #4791, #4793, #4806, #4808)
sync: Add has_changed method to watch::Ref (#4758)

Changed

time: remove src/time/driver/wheel/stack.rs (#4766)
rt: clean up arguments passed to basic scheduler (#4767)
net: be more specific about winapi features (#4764)
tokio: use const initialized thread locals where possible (#4677)
task: various small improvements to LocalKey (#4795)

Fixed
Documented

fs: warn about performance pitfall (#4762)
chore: fix spelling (#4769)
sync: document spurious failures in oneshot (#4777)
sync: add warning for watch in non-Send futures (#4741)
chore: fix typo (#4798)



... (truncated)


Commits

edd172c chore: prepare Tokio v1.20.5 (#5731)
9877fa2 Merge 'tokio-1.18.6' into 'tokio-1.20.x' (#5730)
0f898a3 chore: prepare Tokio v1.18.6 (#5729)
d6a9ef5 tokio: disable default features for mio (#5728)
2a18018 ci: fix CI for 1.18.x branch (#5728)
f3ce29a chore: prepare Tokio v1.20.4 release
0d8fe5f Merge branch 'tokio-1.18.x' into tokio-1.20.x
171ce0f chore: prepare Tokio v1.18.5 release
d6ea7a7 Add T: Unpin bound to ReadHalf::unsplit
ba81945 chore: prepare Tokio 1.20.3 release
Additional commits viewable in compare view




Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

@dependabot rebase will rebase this PR
@dependabot recreate will recreate this PR, overwriting any edits that have been made to it
@dependabot merge will merge this PR after your CI passes on it
@dependabot squash and merge will squash and merge this PR after your CI passes on it
@dependabot cancel merge will cancel a previously requested merge and block automerging
@dependabot reopen will reopen this PR if it is closed
@dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
@dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
@dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
@dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Noah-Kennedy Noah-Kennedy Noah-Kennedy approved these changes

@hds hds hds approved these changes

Assignees
No one assigned
Labels
A-tokio Area: The main tokio crate R-loom Run loom tests on this PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Darksonn @hds @Noah-Kennedy