Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

See if we can update :) #1411

Closed
wants to merge 1 commit into from
Closed

See if we can update :) #1411

wants to merge 1 commit into from

Conversation

LucioFranco
Copy link
Member

Motivation

Solution

@taiki-e
Copy link
Member

taiki-e commented Aug 8, 2019

@LucioFranco I think this blocked on rust-lang/rust#63316

@LucioFranco
Copy link
Member Author

@taiki-e ah yup just checked the toolchain state, we can wait. I assume we will publish the alphas on futures alpha 17 with old nightly. Then we can release another with those both updated, does that sound like a good plan to you?

Gonna close this.

@LucioFranco LucioFranco closed this Aug 8, 2019
@LucioFranco LucioFranco deleted the lucio/update-nightly branch August 8, 2019 17:53
@taiki-e
Copy link
Member

taiki-e commented Aug 8, 2019

I think rust-lang/futures-rs#1676 is the only change that affects tokio at now. However, if rust-lang/futures-rs#1753 merged, publish the alphas will be blocked on rust-lang/rust#63316 (rust-lang/futures-rs#1753 increases the minimum required nightly version of futures-preview to 2019-07-29.).

@LucioFranco
Copy link
Member Author

@taiki-e yeah, I think those things we can support in the next alpha. So I think we will ship with 17 support today and the current toolchain. Then 18 we can update to new futures release and a newer version of rustc/rustfmt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants