fix: improves panic messages when there is no reactor/timer #1789
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I want to preface this by saying I'm not entirely sure if these error messages are exactly accurate but I wanted to take a crack at it.
Motivation
Providing a more actionable error message when tokio expects to be within a runtime. Fixes #1713
Solution
New error messages:
When there is no timer:
When there is no reactor:
I'm not in love with the "you must execute from within the tokio runtime", not sure what the best wording there is, would love some pointers :)