time: report correct error for timers that exceed max duration #2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benesch
force-pushed
the
time-error
branch
2 times, most recently
from
0afa434 to
ae483e5
Compare
|
Unfortunately, |
The fix in the last commit was surgical, but resulted in duplicating the valid-duration check. This commit adds a new field to Entry that tracks the precise nature of the error that occurred, so that the correct error can be returned when `poll_elapsed` is called.
|
Thanks! Done. |
|
Thanks for the rebase + merge! |
Darksonn
added
A-tokio
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A fix for #1953, as discussed with @carllerche on Discord. The first commit is a surgical fix that fixes the error message with as few code changes as possible. The second commit is a more expansive refactoring that avoids the duplicate validation introduced in the first commit— and also ensures that the "at capacity" error is propagated correctly.
Let me know if you'd like me to squash the commits together, or drop the second commit entirely!