Fix all clippy lints in tests #2573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darksonn
reviewed
May 31, 2020
Darksonn
approved these changes
May 31, 2020
Darksonn
added
A-tokio
fegies
added a commit
to fegies/tokio
that referenced
this pull request
Jun 5, 2020
Trying to remove an already expired Timer Wheel entry (called by DelayQueue.reset()) in some cases as described in (tokio-rs#2573) causes panics. This prevents this panic by omitting removal in these cases
jensim
pushed a commit
to jensim/tokio
that referenced
this pull request
Jun 7, 2020
fegies
added a commit
to fegies/tokio
that referenced
this pull request
Jun 11, 2020
Trying to remove an already expired Timer Wheel entry (called by DelayQueue.reset()) in some cases as described in (tokio-rs#2573) causes panics. This prevents this panic by omitting removal in these cases
fegies
added a commit
to fegies/tokio
that referenced
this pull request
Jun 15, 2020
Trying to remove an already expired Timer Wheel entry (called by DelayQueue.reset()) causes panics in some cases as described in (tokio-rs#2573) This prevents this panic by removing the item from the expired queue and not the wheel in these cases
Darksonn
pushed a commit
that referenced
this pull request
Jul 26, 2020
* Add Unit Test demonstrating the issue This test demonstrates a panic that occurs when the user inserts an item with an instant in the past, and then tries to reset the timeout using the returned key * Guard reset_at against removals of expired items Trying to remove an already expired Timer Wheel entry (called by DelayQueue.reset()) causes panics in some cases as described in (#2573) This prevents this panic by removing the item from the expired queue and not the wheel in these cases Fixes: #2473
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit allows
blacklisted_name.Second commit fixes all other warnings .
Third commit updates CI config so that clippy will check tests too.