Fix select macro giving warning when branch's returns never #2678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blasrodri
force-pushed
the
fix-select-macro-unreachable-warning
branch
2 times, most recently
from
b238391 to
274ae25
Compare
|
Can you add a test too? |
Solves tokio-rs#2665 by adding #[allow(unreachable_code)] inside a branch matching arm.
blasrodri
force-pushed
the
fix-select-macro-unreachable-warning
branch
from
274ae25 to
53a6ba7
Compare
Darksonn
added
A-tokio
carllerche
approved these changes
Jul 28, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves #2665 by adding #[allow(unreachable_code)] inside a branch
matching arm.
Motivation
Fixing #2665 after founding out that the error is generated when
an async function is of return type
!(never)Solution
Add
#[allow(unreachable_code)]in the right block to prevent this.