Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add buffer len channel #2755

Closed
wants to merge 1 commit into from

Conversation

blasrodri
Copy link
Contributor

Motivation

#2642

Solution

Comments

This PR is a WIP. I just wanted to put it up to be sure that this is what the user wanted.

@jared-mackey
Copy link

I was also looking into this. One thought I had while poking around is what should buffer_len return when the receiving side has been dropped? It looks like semaphore isn't taking that into account when returning it's available permits.

@Darksonn Darksonn added A-tokio Area: The main tokio crate C-enhancement Category: A PR with an enhancement or bugfix. M-sync Module: tokio/sync labels Aug 12, 2020
@Darksonn Darksonn marked this pull request as draft September 9, 2020 20:29
@Darksonn
Copy link
Contributor

Darksonn commented Sep 9, 2020

Since the PR claims to be a draft, and nothing has happened, I have converted it to a draft.

@blasrodri
Copy link
Contributor Author

Since the PR claims to be a draft, and nothing has happened, I have converted it to a draft.

I never got a reply from the person who raised the issue. I can try to complete it if it makes sense to add it.

@blasrodri blasrodri closed this Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate C-enhancement Category: A PR with an enhancement or bugfix. M-sync Module: tokio/sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants