Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

util: Add TokioContext future #2791

Merged
merged 18 commits into from
Aug 27, 2020
Merged

util: Add TokioContext future #2791

merged 18 commits into from
Aug 27, 2020

Conversation

blasrodri
Copy link
Contributor

Motivation

Run a future on a custom executor using the tokio runtime.
Resolves: #2776

Solution

@blasrodri
tokio-utils: create TokioContext
6fce541 
Run a future on a custom executor using the tokio runtime.
Resolves: tokio-rs#2776
@blasrodri
test passing
e7913a4
@blasrodri
add some docs
473b8d8
@blasrodri
Copy link
Contributor Author

blasrodri commented Aug 24, 2020 •
edited
Loading

Hi @LucioFranco ! This is still a very WIP
Still needs to be polished (at least) with regards to:

  • features (not sure I fully understand how to do it best)
  • docs...

Darksonn
Darksonn reviewed Aug 25, 2020
View reviewed changes
tokio-util/Cargo.toml Outdated Show resolved Hide resolved
tokio-util/src/context.rs Outdated Show resolved Hide resolved
tokio-util/src/context.rs Outdated Show resolved Hide resolved
LucioFranco
LucioFranco requested changes Aug 25, 2020
View reviewed changes
Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking like a great start! Left some comments, let me know if you have any questions.

tokio-util/tests/context.rs Outdated Show resolved Hide resolved
tokio-util/src/context.rs Outdated Show resolved Hide resolved
tokio-util/Cargo.toml Outdated Show resolved Hide resolved
@blasrodri blasrodri requested a review from LucioFranco August 25, 2020 20:07
LucioFranco
LucioFranco requested changes Aug 26, 2020
View reviewed changes
Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Getting close, a few things we need to clean up first!

tokio-util/src/context.rs Show resolved Hide resolved
tokio-util/src/context.rs Show resolved Hide resolved
tokio-util/src/context.rs Outdated Show resolved Hide resolved
tokio-util/src/context.rs Outdated Show resolved Hide resolved
tokio-util/src/context.rs Show resolved Hide resolved
tokio-util/src/lib.rs
@@ -38,4 +38,6 @@ cfg_compat! {
pub mod compat;
}

pub mod context;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hawkw do you think we should feature flag this around rt?

tokio-util/tests/context.rs Show resolved Hide resolved
@Darksonn Darksonn added A-tokio-util Area: The tokio-util crate M-task Module: tokio/task C-enhancement Category: A PR with an enhancement or bugfix. labels Aug 27, 2020
LucioFranco
LucioFranco approved these changes Aug 27, 2020
View reviewed changes
Copy link
Member

@LucioFranco LucioFranco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Left some comments around docs.

tokio-util/src/context.rs Outdated Show resolved Hide resolved
tokio-util/src/context.rs Outdated Show resolved Hide resolved
tokio-util/src/context.rs Show resolved Hide resolved
@LucioFranco
Copy link
Member

I applied the suggestions, will merge once CI passes, thanks @blasrodri for pushing this through!

@LucioFranco LucioFranco changed the title Tokio utils tokio context util: Add TokioContext future Aug 27, 2020
@LucioFranco LucioFranco merged commit d9d909c into tokio-rs:master Aug 27, 2020
@blasrodri blasrodri deleted the tokio-utils-tokio-context branch August 27, 2020 16:06
LucioFranco added a commit that referenced this pull request Oct 14, 2020
@blasrodri @LucioFranco
util: Add TokioContext future (#2791)
7180149 
Co-authored-by: Lucio Franco <luciofranco14@gmail.com>
@LucioFranco LucioFranco mentioned this pull request Oct 14, 2020
Merged
LucioFranco added a commit that referenced this pull request Oct 14, 2020
@blasrodri @LucioFranco
util: Add TokioContext future (#2791)
79db6ba 
Co-authored-by: Lucio Franco <luciofranco14@gmail.com>
LucioFranco added a commit that referenced this pull request Oct 14, 2020
@blasrodri @LucioFranco
util: Add TokioContext future (#2791)
a204bc3 
Co-authored-by: Lucio Franco <luciofranco14@gmail.com>
LucioFranco added a commit that referenced this pull request Oct 14, 2020
@blasrodri @LucioFranco
util: Add TokioContext future (#2791)
b3d95af 
Co-authored-by: Lucio Franco <luciofranco14@gmail.com>
LucioFranco added a commit that referenced this pull request Oct 14, 2020
@blasrodri @LucioFranco
util: Add TokioContext future (#2791)
2bdfc46 
Co-authored-by: Lucio Franco <luciofranco14@gmail.com>
LucioFranco added a commit that referenced this pull request Oct 14, 2020
@blasrodri @LucioFranco
util: Add TokioContext future (#2791)
c1c599c 
Co-authored-by: Lucio Franco <luciofranco14@gmail.com>
LucioFranco added a commit that referenced this pull request Oct 14, 2020
@LucioFranco @blasrodri
util: Add TokioContext future (#2791) (#2958)
85d8029 
Co-authored-by: Lucio Franco <luciofranco14@gmail.com>
Co-authored-by: Blas Rodriguez Irizar <rodrigblas@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Darksonn Darksonn Darksonn left review comments

@LucioFranco LucioFranco LucioFranco approved these changes

Assignees
No one assigned
Labels
A-tokio-util Area: The tokio-util crate C-enhancement Category: A PR with an enhancement or bugfix. M-task Module: tokio/task
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

util: Add a TokioContext future
3 participants
@blasrodri @LucioFranco @Darksonn