time: fix panic on multithreaded runtime shutdown #3226
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All core threads share the same park, and invoke park() followed by shutdown - in parallel. This is quite possibly a bug in the worker (in that it invokes shutdown when it's not done with the parker), but for now work around it by bypassing the timer parker once shutdown is called. Fixes: tokio-rs#2789
carllerche
approved these changes
Dec 7, 2020
Darksonn
added
A-tokio
hawkw
approved these changes
Dec 7, 2020
|
Upon further investigation, this is a bug/deadlock in the MT runtime itself. Withdrawing this PR. |
|
#3228 take precedence over this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All core threads share the same park, and invoke park() followed by shutdown -
in parallel. This is quite possibly a bug in the worker (in that it invokes
shutdown when it's not done with the parker), but for now work around it by
bypassing the timer parker once shutdown is called.
Fixes: #2789
Motivation
Solution