-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add spawn_pinned to tokio-util #3370
Commits on Jan 3, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 9d0ee8d - Browse repository at this point
Copy the full SHA 9d0ee8dView commit details -
tokio-util: add (incomplete) spawn_pinned support
The pinned workers don't shut down when the tokio runtime does, so the included test never completes. The worker count is currently hard-coded with a fixme. PinnedPool does not reset, so if a second runtime is started after the first finishes, spawn_pinned will not work (the first issue about not shutting down the workers prevents this scenario from happening atm).
Configuration menu - View commit details
-
Copy full SHA for 34ccb19 - Browse repository at this point
Copy the full SHA 34ccb19View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1260d6f - Browse repository at this point
Copy the full SHA 1260d6fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4501084 - Browse repository at this point
Copy the full SHA 4501084View commit details -
Configuration menu - View commit details
-
Copy full SHA for cfdbb8b - Browse repository at this point
Copy the full SHA cfdbb8bView commit details
Commits on Jan 4, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 9dd38b9 - Browse repository at this point
Copy the full SHA 9dd38b9View commit details -
Configuration menu - View commit details
-
Copy full SHA for af54d47 - Browse repository at this point
Copy the full SHA af54d47View commit details
Commits on Jan 5, 2021
-
Configuration menu - View commit details
-
Copy full SHA for a621591 - Browse repository at this point
Copy the full SHA a621591View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0df5844 - Browse repository at this point
Copy the full SHA 0df5844View commit details -
Configuration menu - View commit details
-
Copy full SHA for 27df2b2 - Browse repository at this point
Copy the full SHA 27df2b2View commit details
Commits on Sep 28, 2021
-
Revert "Add Jetbrains IDE .idea folder to gitignore"
This reverts commit 9d0ee8d.
Configuration menu - View commit details
-
Copy full SHA for e454f4f - Browse repository at this point
Copy the full SHA e454f4fView commit details -
Configuration menu - View commit details
-
Copy full SHA for c073781 - Browse repository at this point
Copy the full SHA c073781View commit details
Commits on Oct 24, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 0189798 - Browse repository at this point
Copy the full SHA 0189798View commit details
Commits on Oct 29, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 764414c - Browse repository at this point
Copy the full SHA 764414cView commit details -
Configuration menu - View commit details
-
Copy full SHA for ff14408 - Browse repository at this point
Copy the full SHA ff14408View commit details -
Configuration menu - View commit details
-
Copy full SHA for ca7f8e8 - Browse repository at this point
Copy the full SHA ca7f8e8View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9486e32 - Browse repository at this point
Copy the full SHA 9486e32View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2939338 - Browse repository at this point
Copy the full SHA 2939338View commit details
Commits on Oct 30, 2021
-
Configuration menu - View commit details
-
Copy full SHA for ba8b6be - Browse repository at this point
Copy the full SHA ba8b6beView commit details
Commits on Nov 21, 2021
-
Configuration menu - View commit details
-
Copy full SHA for c4cce06 - Browse repository at this point
Copy the full SHA c4cce06View commit details -
Configuration menu - View commit details
-
Copy full SHA for 09839ad - Browse repository at this point
Copy the full SHA 09839adView commit details -
Configuration menu - View commit details
-
Copy full SHA for 24ca0c7 - Browse repository at this point
Copy the full SHA 24ca0c7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5444dda - Browse repository at this point
Copy the full SHA 5444ddaView commit details -
Configuration menu - View commit details
-
Copy full SHA for 45b5435 - Browse repository at this point
Copy the full SHA 45b5435View commit details -
Configuration menu - View commit details
-
Copy full SHA for 75b9bb1 - Browse repository at this point
Copy the full SHA 75b9bb1View commit details
Commits on Nov 25, 2021
-
Configuration menu - View commit details
-
Copy full SHA for e5972b0 - Browse repository at this point
Copy the full SHA e5972b0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ce300f - Browse repository at this point
Copy the full SHA 4ce300fView commit details -
Make spawn_pinned synchronous again, but immediately send the task
This also makes spawn_pinned_blocking pretty redundant, so it is removed.
Configuration menu - View commit details
-
Copy full SHA for 4622c2a - Browse repository at this point
Copy the full SHA 4622c2aView commit details -
Configuration menu - View commit details
-
Copy full SHA for e8e7af9 - Browse repository at this point
Copy the full SHA e8e7af9View commit details
Commits on Nov 26, 2021
-
Synchronously return join handle in spawn_pinned
Also added more error handling and comments. There are still two more error handling issues: 1. `create_task` could panic, which kills the worker. Using `catch_unwind` limits the types you can use for `create_task` too much. We could use AssertUnwindSafe here, but probably shouldn't. 2. If a worker dies for some reason, the pool doesn't heal (recreate the worker). Healing the pool would require more mutable state and mutual exclusion, which might get complicated.
Configuration menu - View commit details
-
Copy full SHA for bd32346 - Browse repository at this point
Copy the full SHA bd32346View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7769e0a - Browse repository at this point
Copy the full SHA 7769e0aView commit details
Commits on Dec 3, 2021
-
Configuration menu - View commit details
-
Copy full SHA for b64edff - Browse repository at this point
Copy the full SHA b64edffView commit details
Commits on Dec 4, 2021
-
Configuration menu - View commit details
-
Copy full SHA for bb6bdb1 - Browse repository at this point
Copy the full SHA bb6bdb1View commit details -
Configuration menu - View commit details
-
Copy full SHA for ff7ad94 - Browse repository at this point
Copy the full SHA ff7ad94View commit details
Commits on Dec 5, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 5e21d68 - Browse repository at this point
Copy the full SHA 5e21d68View commit details -
Configuration menu - View commit details
-
Copy full SHA for b7c4da9 - Browse repository at this point
Copy the full SHA b7c4da9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2067c61 - Browse repository at this point
Copy the full SHA 2067c61View commit details -
Configuration menu - View commit details
-
Copy full SHA for 16e1521 - Browse repository at this point
Copy the full SHA 16e1521View commit details
Commits on Dec 21, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 62f5ec7 - Browse repository at this point
Copy the full SHA 62f5ec7View commit details -
Configuration menu - View commit details
-
Copy full SHA for c130046 - Browse repository at this point
Copy the full SHA c130046View commit details
Commits on Dec 28, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 8aaa3ca - Browse repository at this point
Copy the full SHA 8aaa3caView commit details
Commits on Dec 29, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 9214302 - Browse repository at this point
Copy the full SHA 9214302View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1bd5bf2 - Browse repository at this point
Copy the full SHA 1bd5bf2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 34d3646 - Browse repository at this point
Copy the full SHA 34d3646View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2937f7e - Browse repository at this point
Copy the full SHA 2937f7eView commit details -
Update tokio-util/src/task/spawn_pinned.rs
Co-authored-by: Alice Ryhl <aliceryhl@google.com>
Configuration menu - View commit details
-
Copy full SHA for 5d9bbde - Browse repository at this point
Copy the full SHA 5d9bbdeView commit details -
Configuration menu - View commit details
-
Copy full SHA for fb11c45 - Browse repository at this point
Copy the full SHA fb11c45View commit details