macros: various error message improvements #3677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidpdrsn
added
C-enhancement
davidpdrsn
commented
Apr 5, 2021
Comment on lines
+52
to
+53
| 27 | #[tokio::test(flavor = "foo")] | ||
| | ^^^^^ |
There was a problem hiding this comment.
This would previously point to flavor even though "foo" is the problem.
davidpdrsn
commented
Apr 5, 2021
Comment on lines
+55
to
+59
| error: The `start_paused` option requires the `current_thread` runtime flavor. Use `#[tokio::test(flavor = "current_thread")]` | ||
| --> $DIR/macros_invalid_input.rs:30:55 | ||
| | | ||
| 30 | #[tokio::test(flavor = "multi_thread", start_paused = false)] | ||
| | ^^^^^ |
There was a problem hiding this comment.
Adding Use ... suggestion the user can copy-paste.
davidpdrsn
commented
Apr 5, 2021
Comment on lines
+61
to
+65
| error: Failed to parse value of `worker_threads` as integer. | ||
| --> $DIR/macros_invalid_input.rs:33:57 | ||
| | | ||
| 33 | #[tokio::test(flavor = "multi_thread", worker_threads = "foo")] | ||
| | ^^^^^ |
There was a problem hiding this comment.
Added missing backticks.
Why does CI require this?
Darksonn
approved these changes
Apr 5, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves a few of the error messages for
#[tokio::main]and#[tokio::test]. The changes are probably best illustrated by the new trybuild tests.I also added a note to the docs about
start_pausedrequiring thetest-utilfeature which wasn't mentioned previously. Took me some digging to discover.