util: add lifetime parameter to ReusableBoxFuture #3762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
udoprog
reviewed
May 9, 2021
|
|
||
| // SAFETY: Box::into_raw does not return null pointers. | ||
| let boxed = unsafe { NonNull::new_unchecked(boxed) }; | ||
| let boxed = NonNull::from(Box::leak(boxed)); |
There was a problem hiding this comment.
This is a nice change which should be incorporated even if the overall PR isn't accepted!
There was a problem hiding this comment.
I don't really like going through references though. The unsafety rules get a lot more complicated when you do.
There was a problem hiding this comment.
@Darksonn Box::into_raw actually uses Box::leak internally, and NonNull::from(Box::leak(boxed)) was the reason that Box::into_non_null was decided to not be added, so I am pretty sure that this would be fine.
tobz
added
the
S-breaking-change
tobz
approved these changes
Feb 9, 2022
hawkw
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
ReusableBoxFuturecurrently only supports'staticfutures. However I don't think this limitation is necessary.Solution
Add a lifetime parameter to
ReusableBoxFuturethat represents the lifetime of the contained future.ReusableBoxFuture<T>becomesReusableBoxFuture<'static, T>.This is a breaking change. If that's undesirable, this could potentially be added as a separate type (but I can't think of a good name for it).