Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use OwnedTasks in LocalSet #3950

Merged
merged 2 commits into from
Jul 12, 2021
Merged

Use OwnedTasks in LocalSet #3950

merged 2 commits into from
Jul 12, 2021

Conversation

Darksonn
Copy link
Contributor

@Darksonn Darksonn commented Jul 9, 2021

Replace the LinkedList in LocalSet with OwnedTasks. This introduces an unnecessary mutex, but is part of the transition to a safe task API. The mutex will be removed again in the follow-up PR that handles the Send safety part of the safe task API.

@Darksonn Darksonn added A-tokio Area: The main tokio crate M-runtime Module: tokio/runtime M-task Module: tokio/task labels Jul 9, 2021
Copy link
Member

@carllerche carllerche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@Darksonn Darksonn merged commit 6610ba9 into master Jul 12, 2021
@Darksonn Darksonn deleted the owned-tasks-local branch July 12, 2021 12:42
@Darksonn Darksonn mentioned this pull request Jul 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate M-runtime Module: tokio/runtime M-task Module: tokio/task
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants