Test combinations of task behavior #3967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darksonn
added
A-tokio
|
The loom test did not work with the threaded scheduler because panics could leak from one thread to another due to its use of generators to switch between threads. However, the loom test was useful as it caught memory leaks. Changing it to a miri test retains the leak test as miri will also catch leaks. I also run it as a normal test. I only run the threaded scheduler in the normal test and not in miri. |
Merged
sthagen
added a commit
to sthagen/tokio-rs-tokio
that referenced
this pull request
Jul 22, 2021
runtime: add large test and fix leak it found (tokio-rs#3967)
Darksonn
added a commit
that referenced
this pull request
Jul 22, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.