Replace time crate with httpdate #4169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Darksonn
reviewed
Oct 14, 2021
examples/tinyhttp.rs
Outdated
Comment on lines
268
to
272
| let now = time::get_time(); | ||
| if now >= cache.next_update { | ||
| cache.update(now); | ||
| if let Ok(since_last_update) = cache.last_update.elapsed() { | ||
| if since_last_update > Duration::from_secs(1) { | ||
| cache.update(); | ||
| } |
There was a problem hiding this comment.
It seems like this would misbehave if the clock is moved backwards, though that was probably also the case previously.
There was a problem hiding this comment.
This could be resolved by using Instant for cache & SystemTime only for generating string
There was a problem hiding this comment.
That would work. Another approach would be to always regenerate if the time has gone backwards.
There was a problem hiding this comment.
I see now that the goal of the cache isn't to cache the date for a second, but to cache the date for that particular second
Code updated to store unix second & refresh when second changes
httpdate is used by hyper/warp/headers, & this addresses the time crate used here being 0.1 while latest time crate is 0.3
oliver-giersch
pushed a commit
to oliver-giersch/tokio
that referenced
this pull request
Oct 28, 2021
hawkw
pushed a commit
that referenced
this pull request
Nov 16, 2021
hawkw
pushed a commit
that referenced
this pull request
Nov 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
httpdate is used by hyper/warp/headers,
& this addresses the time crate used here being 0.1 while latest time crate is 0.3