Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: fix racy UnsafeCell access on a closed oneshot #4226

Merged
merged 8 commits into from
Nov 14, 2021
Merged

sync: fix racy UnsafeCell access on a closed oneshot #4226

merged 8 commits into from
Nov 14, 2021

Commits on Nov 12, 2021

  1. loom test for #4225 

    Signed-off-by: Eliza Weisman <eliza@buoyant.io>
    @hawkw
    hawkw committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    844dc9b View commit details
    Browse the repository at this point in the history

  2. oneshot: prioritize closed over complete 

    This fixes the race.

Signed-off-by: Eliza Weisman <eliza@buoyant.io>
    @hawkw
    hawkw committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    c8f82d4 View commit details
    Browse the repository at this point in the history

  3. add a similar test for poll_recv 

    Signed-off-by: Eliza Weisman <eliza@buoyant.io>
    @hawkw
    hawkw committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    5ae003c View commit details
    Browse the repository at this point in the history

  4. also prioritize closed in poll_recv 

    Signed-off-by: Eliza Weisman <eliza@buoyant.io>
    @hawkw
    hawkw committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    a6b60ed View commit details
    Browse the repository at this point in the history

  5. remove dbgs 

    Signed-off-by: Eliza Weisman <eliza@buoyant.io>
    @hawkw
    hawkw committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    54b740d View commit details
    Browse the repository at this point in the history

  6. fix test failing when the channel's closed 

    Signed-off-by: Eliza Weisman <eliza@buoyant.io>
    @hawkw
    hawkw committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    2324301 View commit details
    Browse the repository at this point in the history

  7. restore prev behavior: honor completed over closed 

    Signed-off-by: Eliza Weisman <eliza@buoyant.io>
    @hawkw
    hawkw committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    ef15fba View commit details
    Browse the repository at this point in the history

  8. add comments in set_complete 

    Signed-off-by: Eliza Weisman <eliza@buoyant.io>
    @hawkw
    hawkw committed Nov 12, 2021
    Configuration menu
    Copy the full SHA
    897e71e View commit details
    Browse the repository at this point in the history