io: fix take when using evil reader (backport #4428)
#4434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carllerche
added
A-tokio
|
The CircleCI build will fail due to missing configuration. It shouldn't block merging. |
carllerche
force-pushed
the
merge-4428
branch
2 times, most recently
from
d462643
to
e5121a2
Compare
|
This needs to include #4437. |
|
@Darksonn thanks, I'll pull it in once I wrangle CI. |
carllerche
force-pushed
the
merge-4428
branch
6 times, most recently
from
6313acc
to
8ddb9f7
Compare
|
@Darksonn Ok, I backported the fix as well. |
Darksonn
approved these changes
Jan 30, 2022
carllerche
added a commit
that referenced
this pull request
Jan 30, 2022
When backporting patches to LTS branches, we often run into CI failures due to changes in rust. Newer rust versions add more lints, which break CI. We really don't want to also have to backport patches that fix CI, so instead, LTS branches should pin the stable rust version in CI (e.g. #4434). This PR restructures the CI config files to make it a bit easier to set a specific rust version in CI.
carllerche
force-pushed
the
merge-4428
branch
from
e5e256e
to
b30bc9c
Compare
|
Reordering commit before merge. |
carllerche
added a commit
that referenced
this pull request
Jan 30, 2022
When backporting patches to LTS branches, we often run into CI failures due to changes in rust. Newer rust versions add more lints, which break CI. We really don't want to also have to backport patches that fix CI, so instead, LTS branches should pin the stable rust version in CI (e.g. #4434). This PR restructures the CI config files to make it a bit easier to set a specific rust version in CI.
carllerche
added a commit
that referenced
this pull request
Jan 30, 2022
When backporting patches to LTS branches, we often run into CI failures due to changes in rust. Newer rust versions add more lints, which break CI. We really don't want to also have to backport patches that fix CI, so instead, LTS branches should pin the stable rust version in CI (e.g. #4434). This PR restructures the CI config files to make it a bit easier to set a specific rust version in CI.
carllerche
added a commit
that referenced
this pull request
Jan 31, 2022
When backporting patches to LTS branches, we often run into CI failures due to changes in rust. Newer rust versions add more lints, which break CI. We really don't want to also have to backport patches that fix CI, so instead, LTS branches should pin the stable rust version in CI (e.g. #4434). This PR restructures the CI config files to make it a bit easier to set a specific rust version in CI.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backports #4428 into 1.8.x