Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rt: rename internal runtime::Kind to Scheduler #5017

Merged
merged 2 commits into from
Sep 15, 2022

Conversation

carllerche
Copy link
Member

The runtime::Kind enum doesn't really represent the runtime flavor but is an enumeration of the different scheduler types. This patch renames the enum to reflect this.

At a later time, it is likely the Scheduler enum will be moved to tokio::runtime::scheduler, but that is punted to a later PR.

This rename is to make space for other enums.

The `runtime::Kind` enum doesn't really represent the runtime flavor,
but is an enumeration of the different scheduler types. This patch
renames the enum to reflect this.

At a later time, it is likely the `Scheduler` enum will be moved to
`tokio::runtime::scheduler`, but that is punted to a later PR.

This rename is to make space for other enums
@carllerche carllerche added C-maintenance Category: PRs that clean code up or issues documenting cleanup. A-tokio Area: The main tokio crate M-runtime Module: tokio/runtime labels Sep 15, 2022
@github-actions github-actions bot added the R-loom Run loom tests on this PR label Sep 15, 2022
@carllerche carllerche removed the R-loom Run loom tests on this PR label Sep 15, 2022
@github-actions github-actions bot added the R-loom Run loom tests on this PR label Sep 15, 2022
@carllerche carllerche removed the R-loom Run loom tests on this PR label Sep 15, 2022
@carllerche carllerche merged commit 198e2d8 into master Sep 15, 2022
@carllerche carllerche deleted the rm-rt-kind-to-scheduler branch September 15, 2022 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate C-maintenance Category: PRs that clean code up or issues documenting cleanup. M-runtime Module: tokio/runtime
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants