Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use std::AtomicPtr and std::AtomicU8 #5071

Merged
merged 4 commits into from
Oct 4, 2022

Conversation

xudong963
Copy link
Contributor

Motivation

Some annotations are out of date, and may be misleading.

Solution

Remove useless annotaions.

tokio/src/loom/std/atomic_ptr.rs Show resolved Hide resolved
tokio/src/loom/std/atomic_u32.rs Show resolved Hide resolved
tokio/src/loom/std/atomic_u8.rs Show resolved Hide resolved
@Darksonn Darksonn added A-tokio Area: The main tokio crate M-sync Module: tokio/sync labels Oct 3, 2022
@xudong963 xudong963 changed the title chore: remove useless annotaions for atomic_xxx.rs chore: use std::AtomicPtr and std::AtomicU8 Oct 3, 2022
Copy link
Contributor

@Darksonn Darksonn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Darksonn Darksonn enabled auto-merge (squash) October 4, 2022 09:40
@Darksonn Darksonn merged commit 5dbd8ca into tokio-rs:master Oct 4, 2022
@xudong963 xudong963 deleted the remove_useless_comments branch October 4, 2022 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-tokio Area: The main tokio crate M-sync Module: tokio/sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants