fs: always try to get file type in fs::read_dir
#5804
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation of
fs::read_dir
pre-stores the file type, except for a few operating systems that are known to require an extra call to get the file type. The cfg attributes we use to check such operating systems comes from the std implementation, but this was recently updated and no longer matches.I think I'd rather just delete those cfg attributes, because when we read a directory, we also read the file type, except in very few cases.