rt(alt): fix memory leak and increase max preemption when running Loom CI tests #5911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carllerche
added
A-tokio
github-actions
bot
removed
the
R-loom-multi-thread-alt
github-actions
bot
added
the
R-loom-multi-thread-alt
carllerche
changed the title
Darksonn
approved these changes
Aug 10, 2023
This was referenced Aug 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The memory leak was caused by a bug during shutdown where some state was leaked.
I'm not 100% sure why the loom tests are faster now, but I would guess it is because I removed debug assertion that used atomics (which would also increase the state space to explore).