rt(alt): tweak some constants to improve scalability #5935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch aims to reduce the number of threads that get no-op wakeups.
carllerche
added
A-tokio
github-actions
bot
added
the
R-loom-multi-thread-alt
carllerche
commented
Aug 15, 2023
| @@ -17,6 +17,93 @@ use std::task::{Context, Poll, Waker}; | |||
|
|
|||
| /// Stored in the I/O driver resource slab. | |||
| #[derive(Debug)] | |||
| // # This struct should be cache padded to avoid false sharing. The cache padding rules are copied | |||
There was a problem hiding this comment.
Yes, I know it is time to factor this out into a CachePadded abstraction. I pinky promise I'll do it in a follow-up, but I don't want to mix up concerns in this PR.
Darksonn
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch aims to reduce the number of threads that get no-op wakeups.