-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add apple tvos support #6045
Add apple tvos support #6045
Conversation
6223dd2
to
0ad2444
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Would you be able to add a cargo check
for this target to CI?
tokio/src/lib.rs
Outdated
@@ -393,6 +393,7 @@ | |||
//! * Android (API level 21) | |||
//! * macOS | |||
//! * iOS | |||
//! * tvOS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're not going to add a tier 3 target to this list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rereading it I realize now I shouldn't have touched that, sorry about that.
Thanks. Would you be able to add a cargo check for this target to CI?
Sure, I think so, will add.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can check my last commit where I add the CI job, however this target requires "appropriate versions of Xcode and the SDKs for tvOS (AppleTVOS.sdk) and/or the tvOS Simulator (AppleTVSimulator.sdk) to build a toolchain and target these platforms." As the runner is a x86_64 machine, it cannot build for this target.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we can't add CI, then that's okay. Have you tested that the code works on a real setup?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, so far so good! :)
bda87a3
to
96da98f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
This PR allows using tokio lib to target tier 3 *-apple builds: