Prepare 0.24.0 release #142
Conversation
|
By the way, I'm also happy to lend a hand if you need extra help. |
|
when this will be released ? |
|
I'm hoping to get some feedback from @jtescher (or maybe @davidbarsky?). If I don't get any in, say, 48 hours, I'll merge and publish. |
| @@ -1,10 +1,6 @@ | |||
| [package] | |||
| name = "tracing-opentelemetry" | |||
| version = "0.23.0" | |||
| authors = [ | |||
| "Julian Tescher <julian@tescher.me>", | |||
There was a problem hiding this comment.
this is up to julian; i'd check with him first.
| version = "0.23.0" | ||
| authors = [ | ||
| "Julian Tescher <julian@tescher.me>", | ||
| "Tokio Contributors <team@tokio.rs>" |
There was a problem hiding this comment.
i'd consider keeping this one or getting an otel-specific alias here.
There was a problem hiding this comment.
Given the existence of RFC 3052 and the concerns it enumerates, why?
There was a problem hiding this comment.
i don't have strong feeling; i just think credit is important!
|
|
||
| ### Fixed | ||
|
|
||
| - Set span end time when it exists (#124) |
There was a problem hiding this comment.
i won't block this, but i've mentioned my concerns here: #124 (comment).
This doesn't seem to be useful for a small single crate repository.
|
I'm going forward with this release to unlock the use of opentelemetry 0.23 for the community. @davidbarsky thanks for your feedback -- I've considered it but given the discussion so far I'm still feeling good about the span end time change in #124 and the authors metadata change I made in this PR. @jtescher (or anyone else), happy to have more discussion about the span end time change in #124 and the authors metadata change I made in this PR -- we can revert both changes in a semver-compatible API which I'd be happy to work on if we decide it's needed. |
|
No description provided.