Add set_attribute function #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtescher
added a commit
that referenced
this pull request
Aug 4, 2023
Changelog: ### Added - Add `OpenTelemetrySpanExt::set_attribute` function (#34) ### Breaking Changes - Upgrade to `v0.20.0` of `opentelemetry` (#36) For list of breaking changes in OpenTelemetry, see the [v0.20.0 changelog](https://github.com/open-telemetry/opentelemetry-rust/blob/v0.20.0/opentelemetry-api/CHANGELOG.md#v0200).
|
The 32 field maximum has also been fix over in tracing tokio-rs/tracing#2508 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
set_attributetoOpenTelemetrySpanExtto allow setting attributes directly on the OpenTelemetrySpanBuilder.This allows users to set more than the tracing maximum of 32 fields.
There was a workaround I came up with without using the function involving wrapping the
Registryin an Arc and accessingOtelDatadirectly, but that led to this bug in tracing-subscriber.