Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate from lazy_static to once_cell #2146

Closed
james7132 opened this issue Jun 4, 2022 · 1 comment · Fixed by #2147
Closed

Migrate from lazy_static to once_cell #2146

james7132 opened this issue Jun 4, 2022 · 1 comment · Fixed by #2147

Comments

@james7132
Copy link
Contributor

james7132 commented Jun 4, 2022 •
edited
Loading

Feature Request

Replace lazy_static uses with once_cell::sync::Lazy.

Crates

All with the dependency.

Motivation

lazy_static involves macros, takes a bit longer to compile, and once_cell provides more flexible ways for lazy initizalization, and it's on the way to being added to std.

Proposal

Replace all usages of lazy_static with static VAR: Lazy<T>.

One potential drawback is that lazy_static supports spin-waiting on the result, while Lazy doesn't. I don't think any of tracing's usages are perf-bound by this though.

Alternatives

Wait until it gets into std before making the change.
@notgull
Copy link

notgull commented Jun 4, 2022

One potential drawback is that lazy_static supports spin-waiting on the result, while Lazy doesn't. I don't think any of tracing's usages are perf-bound by this though.

You could use the spin crate instead in this case.

@james7132 james7132 mentioned this issue Jun 5, 2022
Merged
hawkw pushed a commit that referenced this issue Jun 6, 2022
@james7132
core, subscriber: migrate from lazy_static to once_cell (#2147)
10da627 
Replace `lazy_static` with `once_cell`. Fixes #2146.

## Motivation

`lazy_static!`, while a declarative macro, is a macro nonetheless. It
can add quite a bit of additional compilation time cost.
`once_cell::sync::Lazy` does the same thing with generics, and can be
used more flexibly (i.e. non-static lazily initialized values), and has
been proposed to be added to `std` (see linked issue).

I'm trying to reduce the compile time and dependency tree complexity of
a dependent project: [bevy](https://bevyengine.org), which is using
tracing. `lazy_static` and `once_cell` are both in our dependency tree
and both end up doing the same thing.

## Solution

Migrate to `once_cell`.
hawkw pushed a commit that referenced this issue Jun 6, 2022
@james7132 @hawkw
core, subscriber: migrate from lazy_static to once_cell (#2147)
45a1cea 
Replace `lazy_static` with `once_cell`. Fixes #2146.

## Motivation

`lazy_static!`, while a declarative macro, is a macro nonetheless. It
can add quite a bit of additional compilation time cost.
`once_cell::sync::Lazy` does the same thing with generics, and can be
used more flexibly (i.e. non-static lazily initialized values), and has
been proposed to be added to `std` (see linked issue).

I'm trying to reduce the compile time and dependency tree complexity of
a dependent project: [bevy](https://bevyengine.org), which is using
tracing. `lazy_static` and `once_cell` are both in our dependency tree
and both end up doing the same thing.

## Solution

Migrate to `once_cell`.
hawkw pushed a commit that referenced this issue Jun 6, 2022
@james7132 @hawkw
core, subscriber: migrate from lazy_static to once_cell (#2147)
ef4991b 
Replace `lazy_static` with `once_cell`. Fixes #2146.

## Motivation

`lazy_static!`, while a declarative macro, is a macro nonetheless. It
can add quite a bit of additional compilation time cost.
`once_cell::sync::Lazy` does the same thing with generics, and can be
used more flexibly (i.e. non-static lazily initialized values), and has
been proposed to be added to `std` (see linked issue).

I'm trying to reduce the compile time and dependency tree complexity of
a dependent project: [bevy](https://bevyengine.org), which is using
tracing. `lazy_static` and `once_cell` are both in our dependency tree
and both end up doing the same thing.

## Solution

Migrate to `once_cell`.
hawkw pushed a commit that referenced this issue Jun 6, 2022
@james7132 @hawkw
core, subscriber: migrate from lazy_static to once_cell (#2147)
7591fa1 
Replace `lazy_static` with `once_cell`. Fixes #2146.

## Motivation

`lazy_static!`, while a declarative macro, is a macro nonetheless. It
can add quite a bit of additional compilation time cost.
`once_cell::sync::Lazy` does the same thing with generics, and can be
used more flexibly (i.e. non-static lazily initialized values), and has
been proposed to be added to `std` (see linked issue).

I'm trying to reduce the compile time and dependency tree complexity of
a dependent project: [bevy](https://bevyengine.org), which is using
tracing. `lazy_static` and `once_cell` are both in our dependency tree
and both end up doing the same thing.

## Solution

Migrate to `once_cell`.
hawkw pushed a commit that referenced this issue Jun 6, 2022
@james7132 @hawkw
core, subscriber: migrate from lazy_static to once_cell (#2147)
bd014f0 
Replace `lazy_static` with `once_cell`. Fixes #2146.

## Motivation

`lazy_static!`, while a declarative macro, is a macro nonetheless. It
can add quite a bit of additional compilation time cost.
`once_cell::sync::Lazy` does the same thing with generics, and can be
used more flexibly (i.e. non-static lazily initialized values), and has
been proposed to be added to `std` (see linked issue).

I'm trying to reduce the compile time and dependency tree complexity of
a dependent project: [bevy](https://bevyengine.org), which is using
tracing. `lazy_static` and `once_cell` are both in our dependency tree
and both end up doing the same thing.

## Solution

Migrate to `once_cell`.
hawkw pushed a commit that referenced this issue Jun 7, 2022
@james7132 @hawkw
core, subscriber: migrate from lazy_static to once_cell (#2147)
29b265d 
Replace `lazy_static` with `once_cell`. Fixes #2146.

## Motivation

`lazy_static!`, while a declarative macro, is a macro nonetheless. It
can add quite a bit of additional compilation time cost.
`once_cell::sync::Lazy` does the same thing with generics, and can be
used more flexibly (i.e. non-static lazily initialized values), and has
been proposed to be added to `std` (see linked issue).

I'm trying to reduce the compile time and dependency tree complexity of
a dependent project: [bevy](https://bevyengine.org), which is using
tracing. `lazy_static` and `once_cell` are both in our dependency tree
and both end up doing the same thing.

## Solution

Migrate to `once_cell`.
kaffarell pushed a commit to kaffarell/tracing that referenced this issue May 22, 2024
@james7132 @kaffarell
core, subscriber: migrate from lazy_static to once_cell (tokio-rs…
b243b55 
…#2147)

Replace `lazy_static` with `once_cell`. Fixes tokio-rs#2146.

## Motivation

`lazy_static!`, while a declarative macro, is a macro nonetheless. It
can add quite a bit of additional compilation time cost.
`once_cell::sync::Lazy` does the same thing with generics, and can be
used more flexibly (i.e. non-static lazily initialized values), and has
been proposed to be added to `std` (see linked issue).

I'm trying to reduce the compile time and dependency tree complexity of
a dependent project: [bevy](https://bevyengine.org), which is using
tracing. `lazy_static` and `once_cell` are both in our dependency tree
and both end up doing the same thing.

## Solution

Migrate to `once_cell`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Migrate from lazy_static to once_cell
2 participants
@james7132 @notgull