Unknown arguments to #[instrument] are ignored

[mcarton]

Bug Report

Version

└── tracing v0.1.15
    ├── tracing-attributes v0.1.8
    └── tracing-core v0.1.10

Crates

• tracing-attributes

Description

I made the mistake to use

#[instrument(foo="bar", id=1, show=true)]
fn foo() {}

instead of

#[instrument(fields(foo="bar", id=1, show=true))]
//           ^^^^^^^                          ^
fn foo() {}

This is silently accepted by the attribute, but does nothing. I'd expect an error that foo, id and show don't exist, with a possible suggestion to use fields.

[hawkw]

I believe this was fixed in PR #672 --- but it hasn't been released yet. We should get on that!

[hawkw]

I'm closing this as it's a duplicate of #727. We'll try to publish the fix for it soon.