Switch to even more intra-doc links #1084
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(If you want this to land as part of #1078 instead, that's fine too.) |
jyn514
force-pushed
the
even-more-links
branch
from
7d5482f
to
6e261df
Compare
- Convert doc.rust-lang.org links - Convert relative links - Convert `[a](b.html)` links
jyn514
force-pushed
the
even-more-links
branch
from
6e261df
to
7ede450
Compare
|
I think this is as ready for review as it will ever be, #1078 has a lot of broken links due to rustdoc bugs so I wouldn't wait on that. |
davidbarsky
approved these changes
Nov 15, 2020
|
Hmm, I'm not sure why CI is failing - it says the windows job was cancelled? I can't find any relevant logs. |
|
Yup, I canceled the Windows job by accident. Lemme restart it. |
|
I think this is ready to merge :) |
|
Done, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#940
Solution
This converts some more links found while trying to debug the link failures in #1078. Unfortunately it didn't fix the failures, but it's a useful change so I split it out into a separate PR.