subscriber: rename trait CollectorExt to CollectExt #1115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The trait being augmented is the 'Collect' trait, so name the trait that extends it is 'CollectExt'. This is in keeping with the extension trait naming conventions documented in Rust RFC-445, and also with the spirit of the discussion in tokio-rs/tracing PR tokio-rs#1015.
salewski
force-pushed
the
ads/rename-CollectorExt-to-CollectExt
branch
from
6019cff
to
835a81c
Compare
hawkw
approved these changes
Nov 21, 2020
davidbarsky
approved these changes
Nov 21, 2020
|
Thanks for this fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request renames the 'CollectorExt' trait to 'CollectExt'. The trait being augmented is the 'Collect' trait, so name the trait that extends is 'CollectExt'.
This is in keeping with the extension trait naming conventions documented in Rust RFC-445, and also with the spirit of the discussion in tokio-rs/tracing PR #1015.