opentelemetry: rename Layer to Subscriber #1226
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Folyd
requested review from
davidbarsky,
hawkw,
jtescher and
a team
as code owners
|
While this looks good to me, I'm guessing that this shouldn't get backported to the |
|
@davidbarsky yeah this shouldn't get backported |
hawkw
approved these changes
Feb 9, 2021
|
@davidbarsky looks like this pr is just waiting on your 👍 / 👎 |
Folyd
force-pushed
the
rename-opentelemetry
branch
from
cd1050d
to
0ba17b0
Compare
davidbarsky
approved these changes
Mar 1, 2021
|
I think we can get this PR merged? |
|
Looks like I don't have permission to merge this one, @davidbarsky or @hawkw? |
|
Done! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR renames the following:
tracing_opetelemetry::layertotracing_opetelemetry::subscribertracing_opetelemetry::layer::layer()totracing_opetelemetry::subscriber::subscriber()tracing_opetelemetry::layer::OpenTelemetryLayertotracing_opetelemetry::subscriber::OpenTelemetrySubscriberRelated PR: #1015