Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: reverse the polarity of conversions, fix clippy #1335

Merged
merged 6 commits into from
Mar 29, 2021
Merged

chore: reverse the polarity of conversions, fix clippy #1335

merged 6 commits into from
Mar 29, 2021

Commits on Mar 29, 2021

  1. core: reverse the polarity of From/Into conversions 

    Clippy now warns about implementing `Into` rather than `From`, since
`From` automatically provides `Into` but `Into` does not provide `From`.

This fixes the direction of those conversions, placating Clippy.

Signed-off-by: Eliza Weisman <eliza@buoyant.io>
    @hawkw
    hawkw committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    9b2973f View commit details
    Browse the repository at this point in the history

  2. core: remove redundant slice 

    Clippy now warns about this.

Signed-off-by: Eliza Weisman <eliza@buoyant.io>
    @hawkw
    hawkw committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    463d898 View commit details
    Browse the repository at this point in the history

  3. core: reverse more polarities 

    Signed-off-by: Eliza Weisman <eliza@buoyant.io>
    @hawkw
    hawkw committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    bc2474f View commit details
    Browse the repository at this point in the history

  4. tracing: reverse the polarity 

    Signed-off-by: Eliza Weisman <eliza@buoyant.io>
    @hawkw
    hawkw committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    8028b1f View commit details
    Browse the repository at this point in the history

  5. subscriber: reverse polarity 

    Signed-off-by: Eliza Weisman <eliza@buoyant.io>
    @hawkw
    hawkw committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    766c262 View commit details
    Browse the repository at this point in the history

  6. tracing: also reverse polarity in test support 

    Signed-off-by: Eliza Weisman <eliza@buoyant.io>
    @hawkw
    hawkw committed Mar 29, 2021
    Configuration menu
    Copy the full SHA
    2c2d596 View commit details
    Browse the repository at this point in the history