Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement compression in tracing-appender #1779
base: master
Are you sure you want to change the base?
Implement compression in tracing-appender #1779
Changes from 5 commits
53398da
9929826
bb0dfe2
ef1bb10
7593277
74d3655
6601402
2c9f149
248d923
6f4a606
271e3b5
5ff40aa
4a470c3
241ea8f
5d696b6
e76efd3
0bc8b53
eb9803d
a950404
1748b4a
85dbd74
4a1280c
5504a9d
81bfc32
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm not a huge fan of having the builder take several required parameters and then panic if they're not set. Can we consider having the required parameters be passed as arguments to either
RollingFileAppenderBuilder::new()
or toRollingFileAppenderBuilder::build()
? that way, we can ensure at the type level that the parameters that must be provided are present.alternatively, if we can provide a reasonable default for any of these parameters, we could do that if they're unset...but we don't have defaults for these elsewhere. we could, for example, have the rotation parameter default to
Rotation::NEVER
, so that not setting one will build a non-rolling compressed file appender...but then we might want to change the name of the type to justFileAppender
, since it's not always rolling... :)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I did change
new
to accept those 3 parameters: directory, filename, rotation and set rotation default to Rotation::NEVER.